Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Ensure replace() calls only alter the file basename #293

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Oct 20, 2022

This came up while generating a phasediff directory to test #292

@mgxd mgxd marked this pull request as ready for review October 20, 2022 19:22
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Base: 85.37% // Head: 87.28% // Increases project coverage by +1.91% 🎉

Coverage data is based on head (cd4401e) compared to base (1c1a469).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   85.37%   87.28%   +1.91%     
==========================================
  Files          24       25       +1     
  Lines        1928     1982      +54     
  Branches      221      297      +76     
==========================================
+ Hits         1646     1730      +84     
+ Misses        246      219      -27     
+ Partials       36       33       -3     
Flag Coverage Δ
travis 85.38% <100.00%> (+0.01%) ⬆️
unittests 87.18% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/fieldmaps.py 99.41% <100.00%> (+<0.01%) ⬆️
sdcflows/conftest.py 0.00% <0.00%> (ø)
sdcflows/workflows/outputs.py 93.54% <0.00%> (+1.61%) ⬆️
sdcflows/interfaces/reportlets.py 89.83% <0.00%> (+1.69%) ⬆️
sdcflows/interfaces/bspline.py 88.00% <0.00%> (+5.33%) ⬆️
sdcflows/interfaces/fmap.py 87.35% <0.00%> (+14.94%) ⬆️
sdcflows/workflows/fit/syn.py 69.82% <0.00%> (+21.30%) ⬆️
sdcflows/utils/phasemanip.py 94.02% <0.00%> (+28.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgxd mgxd merged commit 83b064e into nipreps:master Oct 21, 2022
@mgxd mgxd deleted the fix/fieldmap-replace branch October 21, 2022 13:43
@effigies effigies added this to the 2.2.0 milestone Dec 6, 2022
effigies pushed a commit to effigies/sdcflows that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

4 participants