Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Change os.basename to os.path.basename #419

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

smeisler
Copy link
Contributor

Addresses bug found in https://neurostars.org/t/attributeerror-module-os-has-no-attribute-basename/27604/2.

An instance of os.basename is leading to errors since it should be os.path.basename.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b073fbf) 76.59% compared to head (3a9d9fa) 76.59%.

Files Patch % Lines
sdcflows/interfaces/fmap.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   76.59%   76.59%           
=======================================
  Files          32       32           
  Lines        2824     2824           
  Branches      373      373           
=======================================
  Hits         2163     2163           
  Misses        595      595           
  Partials       66       66           
Flag Coverage Δ
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mgxd mgxd merged commit 00a2978 into nipreps:master Dec 20, 2023
17 of 18 checks passed
@smeisler
Copy link
Contributor Author

I realize I forgot to add myself to contributors list, will open a new PR for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants