Skip to content

Commit

Permalink
Bump types-protobuf to 3.19.0 (#334)
Browse files Browse the repository at this point in the history
  • Loading branch information
nipunn1313 authored Jan 10, 2022
1 parent d22e0ee commit 7be917a
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
- Remove unnecessary `...` in generated files.
- Reorder/reference enum classes to avoid forward references.
- Support `*_FIELD_NUMBER` for extensions
- Bump types-protobuf dependency to 3.18
- Bump types-protobuf dependency to 3.19
- Internal: Get tests to pass on pure-python protobuf impl (minor semantic differences)
- Internal: Bump pyright in testing to 1.1.206

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ Earlier releases might work, but aren't tested

## Requirements to run typecheckers on stubs generated by mypy-protobuf
Earlier releases might work, but aren't tested
- [mypy >= v0.930](https://pypi.org/project/mypy) or [pyright >= 1.1.206](https://github.com/microsoft/pyright)
- [python-protobuf >= 3.19.1](https://pypi.org/project/protobuf/) - matching protoc release
- [mypy >= v0.931](https://pypi.org/project/mypy) or [pyright >= 1.1.206](https://github.com/microsoft/pyright)
- [python-protobuf >= 3.19.0](https://pypi.org/project/protobuf/) - matching protoc release
- [types-protobuf==3.18.2](https://pypi.org/project/types-protobuf/) - for stubs from the google.protobuf library

### To run typecheckers on code generated with grpc plugin - you'll additionally need
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ py_modules =
mypy_protobuf.extensions_pb2
install_requires =
protobuf>=3.19.1
types-protobuf>=3.18.4
types-protobuf>=3.19.0
python_requires = >=3.6

[options.entry_points]
Expand Down
2 changes: 1 addition & 1 deletion test_negative/output.expected.3.8

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test_negative/output.expected.3.8.omit_linenos
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ test_negative/negative_3.8.py: note: This violates the Liskov substitution princ
test_negative/negative_3.8.py: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
test_negative/negative_3.8.py: error: Return type "Iterator[DummyReply]" of "StreamUnary" incompatible with return type "DummyReply" in supertype "DummyServiceServicer" [override]
test_negative/negative.py: error: "Simple1" has no attribute "SerializeToStringg" [attr-defined]
test_negative/negative.py: error: Argument 1 to "ParseFromString" of "Message" has incompatible type "Simple1"; expected "ByteString" [arg-type]
test_negative/negative.py: error: Argument 1 to "ParseFromString" of "Message" has incompatible type "Simple1"; expected "bytes" [arg-type]
test_negative/negative.py: error: Argument 1 to "CopyFrom" of "Message" has incompatible type "bytes"; expected "Simple1" [arg-type]
test_negative/negative.py: error: Argument 1 to "extend" of "list" has incompatible type "RepeatedScalarFieldContainer[str]"; expected "Iterable[int]" [arg-type]
test_negative/negative.py: error: Argument "foo" to "TestMessage" has incompatible type "int"; expected "str" [arg-type]
Expand Down
2 changes: 1 addition & 1 deletion test_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ protobuf>=3.19.1
pytest==6.2.5
grpc-stubs==1.24.7
grpcio-tools==1.43.0
types-protobuf>=3.18.4
types-protobuf>=3.19.0

0 comments on commit 7be917a

Please sign in to comment.