MNT: Officially deprecate nisext #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.38% // Head: 92.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1170 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 98 98
Lines 12257 12257
Branches 2520 2520
=======================================
Hits 11324 11324
Misses 612 612
Partials 321 321 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Looks fine to me. We should should probably get Dipy to remove their use of Nisext in their |
|
@skoudoro Do you all still use these rules? https://github.com/dipy/dipy/blob/089a02ad0520895bd30370591f965c685293e480/Makefile#L80-L97 |
effigies
force-pushed
the
mnt/deprecate-nisext
branch
from
27d636f to
290e34a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matthew-brett Does this seem like enough, or do we need to be doing anything else to warn the (possibly nonexistent) user base?