Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Assorted refurb suggestions #1270

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@DimitriPapadopoulos DimitriPapadopoulos changed the title Assorted refurb suggestions MNT: Assorted refurb suggestions Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1ee4983) 92.24% compared to head (c1c38c1) 92.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   92.24%   92.24%   -0.01%     
==========================================
  Files          99       99              
  Lines       12455    12452       -3     
  Branches     2561     2560       -1     
==========================================
- Hits        11489    11486       -3     
  Misses        643      643              
  Partials      323      323              
Files Coverage Δ
nibabel/cifti2/cifti2.py 96.87% <100.00%> (ø)
nibabel/cifti2/parse_cifti2.py 83.90% <100.00%> (ø)
nibabel/cmdline/ls.py 77.21% <ø> (ø)
nibabel/freesurfer/io.py 94.24% <100.00%> (ø)
nibabel/gifti/gifti.py 93.26% <100.00%> (ø)
nibabel/gifti/parse_gifti_fast.py 85.53% <100.00%> (ø)
nibabel/nifti1.py 92.76% <100.00%> (-0.03%) ⬇️
nibabel/streamlines/array_sequence.py 97.90% <100.00%> (ø)
nibabel/viewers.py 95.49% <100.00%> (ø)
nibabel/cmdline/parrec2nii.py 90.41% <0.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Suggested by refurb:
[FURB109]: Replace `in [x, y, z]` with `in (x, y, z)`
Suggested by refurb:
[FURB138]: Consider using list comprehension
@effigies
Copy link
Member

effigies commented Nov 7, 2023

Thanks!

@effigies effigies merged commit 6ba501e into nipy:master Nov 7, 2023
50 of 52 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the refurb branch November 7, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants