RF: Use numpy.lib.scimath to demonstrate warning context manager
#1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `numpy.lib.scimath` instead of deprecated `numpy.core.fromnumeric` in `clear_and_catch_warnings` context manager doctests. Take advantage of the commit to add an actual case that would raise a warning. Fixes: ``` nibabel/testing/__init__.py::nibabel.testing.clear_and_catch_warnings <doctest nibabel.testing.clear_and_catch_warnings[1]>:1: DeprecationWarning: numpy.core is deprecated and has been renamed to numpy._core. The numpy._core namespace contains private NumPy internals and its use is discouraged, as NumPy internals can change without warning in any release. In practice, most real-world usage of numpy.core is to access functionality in the public NumPy API. If that is the case, use the public NumPy API. If not, you are using NumPy internals. If you would still like to access an internal attribute, use numpy._core.fromnumeric. ``` raised for example at: https://github.com/nipy/nibabel/actions/runs/9692730430/job/26746686623#step:7:195
|
First I used |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
==========================================
- Coverage 92.20% 92.19% -0.01%
==========================================
Files 98 98
Lines 12398 12398
Branches 2556 2556
==========================================
- Hits 11431 11430 -1
Misses 644 644
- Partials 323 324 +1 ☔ View full report in Codecov by Sentry. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
numpy.lib.scimathinstead of deprecatednumpy.core.fromnumericinclear_and_catch_warningscontext manager doctests.Take advantage of the commit to add an actual case that would raise a warning.
Fixes:
raised for example at:
https://github.com/nipy/nibabel/actions/runs/9692730430/job/26746686623#step:7:195