Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Apply ruff rules (RUF) #1372

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.37%. Comparing base (d9c479a) to head (406e27a).

Files with missing lines Patch % Lines
nibabel/cmdline/dicomfs.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   95.37%   95.37%   -0.01%     
==========================================
  Files         207      207              
  Lines       29672    29671       -1     
  Branches     3018     3018              
==========================================
- Hits        28300    28299       -1     
  Misses        934      934              
  Partials      438      438              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

nibabel/volumeutils.py Outdated Show resolved Hide resolved
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the RUF branch 3 times, most recently from 9b69ecb to c08a1c4 Compare October 9, 2024 07:43
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft October 9, 2024 07:43
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review October 9, 2024 07:51
nibabel/cmdline/dicomfs.py Outdated Show resolved Hide resolved
nibabel/cifti2/cifti2.py Outdated Show resolved Hide resolved
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the RUF branch 5 times, most recently from a327e4a to 50a7fb2 Compare October 9, 2024 20:16
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft November 24, 2024 19:23
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review November 24, 2024 19:23
DimitriPapadopoulos and others added 6 commits November 24, 2024 20:23
RUF012 Mutable class attributes should be annotated with `typing.ClassVar`

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
RUF017 Avoid quadratic list summation
RUF021 Parenthesize `a and b` expressions when chaining `and` and `or` together,
       to make the precedence clear

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
RUF023 `__slots__` is not sorted
RUF031 Avoid parentheses for tuples in subscripts.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants