-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/ci and pre-commit updates #493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 20 20
Lines 4044 4045 +1
Branches 1118 1118
=======================================
+ Hits 3357 3358 +1
Misses 491 491
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pydra/engine/workers.py
Outdated
try: | ||
from dask.distributed import Client | ||
except ImportError: | ||
logger.critical("Please instiall Dask distributed.") | ||
raise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this import is in init so it gets caught at the point of initialization of the worker, not when the worker is executed, which is an async function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this move seems to be done for styling rather than code. you can mark something to be ignored by styling if that is a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will work on flask settings, not on the code
Acknowledgment
Types of changes
Summary
fixes #484 fixes #478
release.yml
all changes to the code were due to flake/codespells complaints...
Checklist
(we are using
black
: you canpip install pre-commit
,run
pre-commit install
in thepydra
directoryand
black
will be run automatically with each commit)