Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/ci and pre-commit updates #493

Merged
merged 14 commits into from
Sep 3, 2021
Merged

Conversation

djarecka
Copy link
Collaborator

@djarecka djarecka commented Aug 31, 2021

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

fixes #484 fixes #478

  • Updating GA workflows:
    • some changes for styles check
    • adding release.yml
  • adding more checks to pre-commit
  • fixing doc builds

all changes to the code were due to flake/codespells complaints...

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #493 (e3b1ded) into master (fe8fe66) will increase coverage by 0.00%.
The diff coverage is 86.36%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          20       20           
  Lines        4044     4045    +1     
  Branches     1118     1118           
=======================================
+ Hits         3357     3358    +1     
  Misses        491      491           
  Partials      196      196           
Flag Coverage Δ
unittests 82.94% <86.36%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/audit.py 88.88% <ø> (ø)
pydra/engine/boutiques.py 84.46% <ø> (ø)
pydra/engine/helpers_state.py 90.00% <ø> (ø)
pydra/engine/submitter.py 84.45% <ø> (ø)
pydra/engine/task.py 87.85% <ø> (ø)
pydra/utils/messenger.py 94.28% <ø> (ø)
pydra/engine/workers.py 31.77% <50.00%> (+0.32%) ⬆️
pydra/engine/graph.py 92.69% <75.00%> (ø)
pydra/engine/core.py 89.10% <100.00%> (ø)
pydra/engine/helpers.py 79.57% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe8fe66...e3b1ded. Read the comment docs.

@djarecka djarecka changed the title Ci/ci updates Ci/ci and pre-commit updates Sep 2, 2021
Comment on lines 359 to 363
try:
from dask.distributed import Client
except ImportError:
logger.critical("Please instiall Dask distributed.")
raise
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this import is in init so it gets caught at the point of initialization of the worker, not when the worker is executed, which is an async function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this move seems to be done for styling rather than code. you can mark something to be ignored by styling if that is a problem.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will work on flask settings, not on the code

@djarecka djarecka merged commit 9630aa8 into nipype:master Sep 3, 2021
@djarecka djarecka deleted the ci/ci_updates branch December 30, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleaning up CI and release processes doc building failing on circle ci
2 participants