Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Drop Python 3.7 support #669

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

effigies
Copy link
Contributor

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

  • Drops Python 3.7 support

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.21 ⚠️

Comparison is base (426564e) 81.77% compared to head (c9989ba) 81.56%.

❗ Current head c9989ba differs from pull request most recent head 6ec7755. Consider uploading reports for the commit 6ec7755 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
- Coverage   81.77%   81.56%   -0.21%     
==========================================
  Files          20       20              
  Lines        4400     4400              
  Branches     1264        0    -1264     
==========================================
- Hits         3598     3589       -9     
- Misses        798      811      +13     
+ Partials        4        0       -4     
Flag Coverage Δ
unittests 81.56% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Contributor Author

@mgxd Do you know where your Dockerfile is that you used to build https://hub.docker.com/r/mgxd/slurm? We need to update it with a newer Python.

@djarecka
Copy link
Collaborator

There is also a newer container that was found here: #667
but I haven't had time to check why some tests are failing

@djarecka djarecka merged commit 9de0560 into nipype:master Jul 21, 2023
@effigies effigies deleted the mnt/drop-37 branch July 21, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants