-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing bugfixes #687
Typing bugfixes #687
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
==========================================
- Coverage 83.23% 82.88% -0.35%
==========================================
Files 22 22
Lines 4848 4873 +25
Branches 1392 0 -1392
==========================================
+ Hits 4035 4039 +4
- Misses 809 834 +25
+ Partials 4 0 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
b26c22b
to
64c5779
Compare
…ultiple args (e.g. mrconvert --export_grad_fsl bvec.bvec bval.bval)
64c5779
to
9fabcb3
Compare
@djarecka I believe this is ready to merge now. The new SLURM test seems to be getting stuck somewhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments. Nothing objectionable here, though I also did not fully grasp the bugs being fixed.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Merging so #684 can be rebased on |
Types of changes
Summary
output_file_template
definedoutput_file_template
to define tuple/list templates for options with multiple files paths (e.g. mrconvert --export_grad_fsl BVEC BVAL)Checklist