Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding cache_dir to tests #704

Merged
merged 1 commit into from
Sep 15, 2023
Merged

adding cache_dir to tests #704

merged 1 commit into from
Sep 15, 2023

Conversation

djarecka
Copy link
Collaborator

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

some tests were missing cache_dir=tmp_path

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.43% ⚠️

Comparison is base (8579921) 83.42% compared to head (0205f33) 82.99%.
Report is 1 commits behind head on master.

❗ Current head 0205f33 differs from pull request most recent head 4937232. Consider uploading reports for the commit 4937232 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   83.42%   82.99%   -0.43%     
==========================================
  Files          22       22              
  Lines        4894     4894              
  Branches     1410        0    -1410     
==========================================
- Hits         4083     4062      -21     
- Misses        807      832      +25     
+ Partials        4        0       -4     
Flag Coverage Δ
unittests 82.99% <ø> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djarecka djarecka merged commit e425b83 into nipype:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant