-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BYO worker #733
BYO worker #733
Conversation
…nkey path the pydra.engine.workers.WORKERS dict
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
==========================================
+ Coverage 83.35% 83.52% +0.17%
==========================================
Files 24 24
Lines 4949 4964 +15
Branches 1411 1411
==========================================
+ Hits 4125 4146 +21
+ Misses 816 812 -4
+ Partials 8 6 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this approach in general. Small comments for your consideration.
Types of changes
Summary
Adds the ability to supply your own worker, i.e. one not already defined in the pydra core, without it needing to monkey patch the pydra.engine.workers.WORKERS dict
Checklist