Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYO worker #733

Merged
merged 5 commits into from
Mar 1, 2024
Merged

BYO worker #733

merged 5 commits into from
Mar 1, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Feb 25, 2024

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

Adds the ability to supply your own worker, i.e. one not already defined in the pydra core, without it needing to monkey patch the pydra.engine.workers.WORKERS dict

Checklist

  • [ x ] I have added tests to cover my changes (if necessary)

…nkey path the pydra.engine.workers.WORKERS dict
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (1720ba6) to head (24402f5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   83.35%   83.52%   +0.17%     
==========================================
  Files          24       24              
  Lines        4949     4964      +15     
  Branches     1411     1411              
==========================================
+ Hits         4125     4146      +21     
+ Misses        816      812       -4     
+ Partials        8        6       -2     
Flag Coverage Δ
unittests 83.52% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this approach in general. Small comments for your consideration.

pydra/engine/submitter.py Show resolved Hide resolved
pydra/engine/submitter.py Outdated Show resolved Hide resolved
@ghisvail ghisvail merged commit 6f12146 into master Mar 1, 2024
43 checks passed
@ghisvail ghisvail deleted the enh/byo-worker branch March 1, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants