Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add more complete format string implementation for argstrings #754

Merged
merged 5 commits into from
May 29, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented May 22, 2024

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

Adds support for using getitem within argstr formatters, e.g.

"-coord {coord[0]} {coord[1]}..."

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@tclose tclose added enhancement New feature or request minor Increment the minor version when merged (label from auto) labels May 22, 2024
@tclose tclose requested review from djarecka and effigies May 22, 2024 23:49
pydra/engine/helpers.py Outdated Show resolved Hide resolved
tclose and others added 3 commits May 24, 2024 09:06
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 2.63158% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 15.14%. Comparing base (e52e32b) to head (7d84fba).
Report is 2 commits behind head on master.

Current head 7d84fba differs from pull request most recent head fc3b31f

Please upload reports for the commit fc3b31f to get more accurate results.

Files Patch % Lines
pydra/engine/tests/test_helpers.py 0.00% 25 Missing ⚠️
pydra/engine/helpers.py 7.69% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #754       +/-   ##
===========================================
- Coverage   84.27%   15.14%   -69.14%     
===========================================
  Files          26       53       +27     
  Lines        5127    15693    +10566     
  Branches     1447     2788     +1341     
===========================================
- Hits         4321     2376     -1945     
- Misses        800    12988    +12188     
- Partials        6      329      +323     
Flag Coverage Δ
unittests 15.10% <2.63%> (-69.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies changed the title adds support for getitems in argstring formatting ENH: Add more complete format string implementation for argstrings May 29, 2024
@effigies effigies merged commit 00b92ec into master May 29, 2024
41 checks passed
@effigies effigies deleted the enh/getitem-formatters branch May 29, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Increment the minor version when merged (label from auto)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants