Skip to content

Commit

Permalink
Upgrade to minikube 1.33.0
Browse files Browse the repository at this point in the history
Minikube 1.33.0 adds useful features, fixes, and performance
improvements, but we could not use it because of a regression in
systemd-resolved[1].

A critical change in 1.33.0 is upgrading the kernel to 5.10.207. This
version fixes bad bug with minikube 1.32.0, when qemu assertion fails
while starting a kubevirt VM[2] on newer Intel CPUs (i7-12700k).

Now that we setup systemd-resolved configuration we can upgrade to
minikube 1.33.0, and Alex can run drenv kubevirt environment without
manual hacks.

This change:
- Updates the docs that latest minikube test is 1.33.0
- Setup minikube by default when creating the virtual environment, so
  minikube 1.33.0 support is added transparently for developers
- Setup drenv in the e2e job to support minikube 1.33.0
- Cleanup drenv in the e2e job so setup from previous build will not
  leak into the next build

[1] kubernetes/minikube#18705
[2] https://gitlab.com/qemu-project/qemu/-/issues/237

Thanks: Alex Kalenyuk <akalenyu@redhat.com>
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
  • Loading branch information
nirs committed May 7, 2024
1 parent bce6939 commit fa12baf
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 2 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ jobs:
- name: Install drenv
run: pip install -e test

- name: Setup drenv
working-directory: test
run: drenv setup -v

- name: Install ramenctl
run: pip install -e ramenctl

Expand Down Expand Up @@ -68,3 +72,8 @@ jobs:
if: ${{ always() }}
working-directory: test
run: drenv delete --name-prefix ${{ env.NAME_PREFIX }} envs/regional-dr.yaml

- name: Cleanup drenv
if: ${{ always() }}
working-directory: test
run: drenv cleanup -v
2 changes: 1 addition & 1 deletion docs/user-quick-start.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ enough resources:
sudo dnf install https://storage.googleapis.com/minikube/releases/latest/minikube-latest.x86_64.rpm
```

Tested with version v1.31.
Tested with version v1.33.0.

1. Validate the installation

Expand Down
3 changes: 3 additions & 0 deletions hack/make-venv
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ cp coverage.pth $venv/lib/python*/site-packages
echo "Adding venv symlink..."
ln -sf $venv/bin/activate venv

echo "Setting up minikube for drenv"
$venv/bin/drenv setup -v

echo
echo "To activate the environment run:"
echo
Expand Down
2 changes: 1 addition & 1 deletion test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ environment.
```

You need `minikube` version supporting the `--extra-disks` option.
Tested with version v1.31.2.
Tested with version v1.33.0.

1. Install the `kubectl` tool. See
[Install and Set Up kubectl on Linux](https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/)
Expand Down

0 comments on commit fa12baf

Please sign in to comment.