Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[+] Add DialogUtils class for displaying different dialogs #3

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[+] Add DialogUtils class for displaying different dialogs #3

wants to merge 1 commit into from

Conversation

pranaypatel512
Copy link

#2

@hendrawd
Copy link

I think keeping Dialog in private static ProgressDialog mProgressDialog; as static variable might lead to Activity leak, since it will keep the reference to the activity context then the activity can't be garbage collected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranaypatel512 @hendrawd