Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings in test projects #1078

Merged

Conversation

artem-iron
Copy link
Contributor

This pull request addresses some warnings that emerge on build of test projects. The warnings in the main projects are not addressed.

Namely, some warnings that are fixed:

  • Warnings about exception rethrows
  • Some tests for obsolete methods and members are marked as obsolete
  • Use of Boldweight obsolete property (changed it to use IsBold where suitable)
  • Removed (or commented out) some unused variables

No new failing tests were generated with this change.

test.runsettings file is made to use forward slash in paths, to make it usable when running unix or macos tests.

@tonyqus
Copy link
Member

tonyqus commented May 14, 2023

LGTM

@tonyqus tonyqus merged commit 90d7d52 into nissl-lab:master May 14, 2023
@tonyqus tonyqus added this to the NPOI 2.6.1 milestone May 14, 2023
@artem-iron artem-iron deleted the fix-test-warnings-upstream branch May 15, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants