fixes crash on Android re-enter app #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitaliano#999 The MapView has a locationPlugin that is registered with the locationEngine, and it never got removed when the view was torn down. This will tell the LocationPlugin to stop when the view is detached. However, the Lost Engine is still active in the background. This patch simply lets you press back to close the app, and then re-enter without a crash
|
@nitaliano This seems to fix the crash in our app, but the LocationEngine is still active when the app is backgrounded (or the MainActivity is destroyed). With this change, you can successfully kill the activity and reenter. No more DeadObjectException. |
|
Awesome! I'll test this out. It might still be active in the background due to the telemetry service also using it. |
cpetzel
commented
Jan 27, 2018
| @Override | ||
| public void onViewAttachedToWindow(View v) { | ||
| if(mLocationLayer != null){ | ||
| mLocationLayer.onStart(); |
There was a problem hiding this comment.
@nitaliano might want to wrap this onStart call with the same logic in setReactShowUserLocation()
setReactShowUserLocation(mShowUserLocation)
|
We tried your branch and we still got the crash :/ |
|
closing this in favor of #1010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#999 #925
The RCTMGLMapView has a LocationLayer that is registered with the locationEngine, and it never got removed when the view was torn down. This will tell the LocationLayer to stop when the view is detached.
However, the Lost Engine is still active in the background. This patch simply lets you press back to close the app, and then re-enter without a crash