[Hub Generated] Review request for Microsoft.Insights to add version …

…preview/2020-05-01-preview (Azure#10891) * change enum operator and failingPeriods type * add 2020-05-preview Co-authored-by: Moshe Malka <momalka@microsoft.com>
nitegupt · Sep 25, 2020 · a0f528e · a0f528e
1 parent e27456c
commit a0f528e
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/...esource-manager/Microsoft.Insights/preview/2020-05-01-preview/scheduledQueryRule_API.json b/...esource-manager/Microsoft.Insights/preview/2020-05-01-preview/scheduledQueryRule_API.json
@@ -511,7 +511,7 @@
             "LessThanOrEqual"
           ],
           "x-ms-enum": {
-            "name": "Operator",
+            "name": "conditionOperator",
             "modelAsString": true
           },
           "description": "The criteria operator."
@@ -526,11 +526,15 @@
           "description": "The minimum number of violations required within the selected lookback time window required to raise an alert.",
           "properties": {
             "numberOfEvaluationPeriods": {
-              "type": "number",
+              "type": "integer",
+              "format": "int64",
+              "default": 1,
               "description": "The number of aggregated lookback points. The lookback time window is calculated based on the aggregation granularity (windowSize) and the selected number of aggregated points. Default value is 1"
             },
             "minFailingPeriodsToAlert": {
-              "type": "number",
+              "type": "integer",
+              "format": "int64",
+              "default": 1,
               "description": "The number of violations to trigger an alert. Should be smaller or equal to numberOfEvaluationPeriods. Default value is 1"
             }
           }
@@ -558,7 +562,7 @@
             "Exclude"
           ],
           "x-ms-enum": {
-            "name": "operator",
+            "name": "dimensionOperator",
             "modelAsString": true
           }
         },

diff --git a/specification/monitor/resource-manager/readme.python.md b/specification/monitor/resource-manager/readme.python.md
@@ -30,6 +30,7 @@ Generate all API versions currently shipped for this package
 
 ```yaml $(multiapi) && !$(track2)
 batch:
+  - tag: package-2020-05-preview
   - tag: package-2020-01-01-preview-only
   - tag: package-2019-10-17-preview-only
   - tag: package-2019-06-01-only
@@ -54,6 +55,7 @@ batch:
 ```yaml $(multiapi) && $(track2)
 clear-output-folder: true
 batch:
+  - tag: package-2020-05-preview
   - tag: package-2020-01-01-preview-only
   - tag: package-2019-10-17-preview-only
   - tag: package-2019-06-01-only
@@ -82,6 +84,19 @@ clear-output-folder: false
 perform-load: false
 ```
 
+### Tag: package-2020-05-preview and python
+
+These settings apply only when `--tag=package-2020-05-preview --python` is specified on the command line.
+Please also specify `--python-sdks-folder=<path to the root directory of your azure-sdk-for-python clone>`.
+
+``` yaml $(tag) == 'package-2020-05-preview'
+namespace: $(python-base-namespace).v2020_05_01_preview
+output-folder: $(python-sdks-folder)/$(python-base-folder)/v2020_05_01_preview
+python:
+  namespace: $(python-base-namespace).v2020_05_01_preview
+  output-folder: $(python-sdks-folder)/$(python-base-folder)/v2020_05_01_preview
+```
+
 ### Tag: package-2020-01-01-preview-only and python
 
 These settings apply only when `--tag=package-2020-01-01-preview-only --python` is specified on the command line.