Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added re-render #10

Merged
merged 9 commits into from
Apr 5, 2018
Merged

Added re-render #10

merged 9 commits into from
Apr 5, 2018

Conversation

Sunshine168
Copy link
Collaborator

emmm, btw i found out two points

  • comments only in with-comments branch ~, but thought comments should be in master will be better . or i will add comments in comments branch

  • Seem my workspace format the code

@nitin42
Copy link
Owner

nitin42 commented Mar 3, 2018

Thanks! Can you show me a gif of this ? would be much better to interpret the results.

@Sunshine168
Copy link
Collaborator Author

imgpro

gif is showing process in worker . And i keeping thinking how to improve experience for this feature

And i updated the demo in public folder

@nitin42
Copy link
Owner

nitin42 commented Mar 4, 2018

Exciting!

@nitin42
Copy link
Owner

nitin42 commented Mar 4, 2018

I'll review your PR sometime later today or may be tomorrow (just a little busy with some other work). Awesome job!

Thanks!

@Sunshine168
Copy link
Collaborator Author

okay !

@Sunshine168
Copy link
Collaborator Author

~ hi any news ?

@Sunshine168
Copy link
Collaborator Author

BTW i am interesting be a maintainers for this lib

@nitin42
Copy link
Owner

nitin42 commented Mar 31, 2018

Added you as a collaborator on this project. Thank you so much for your contributions!

@Sunshine168
Copy link
Collaborator Author

🤣 Glad to hear that

@Sunshine168
Copy link
Collaborator Author

Hi @nitin42 I plan to add unit test for this feat and publish a new version . What is a good way for i to contact you , using email or twitter ? And did you having some work about #8

@Sunshine168 Sunshine168 merged commit 36f5995 into nitin42:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants