I forked your code - take a look #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 17, 2023 15:39
…ave you been in a rewrite? Somethings are strange. I marked them with "TODO".
…kens from works. ngramcache still buggy.
…eted other tests that make no sense any more.
Closed
|
Very great addition. I'm excited to strip out AI model for this package for one app running in production. I'd really appreciate & love to see this merged, Nito. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI @nitotm
I forked your code. Please do a separate checkout and give it a look:
https://github.com/eurosat7/efficient-language-detector
If it is not too scary you can use this pull request so you can get my changes into your repository.
hf!