fix: disable externals with explicit flag

nuxt/framework#226
nitrojs · Apr 11, 2022 · 2e5de6c · 2e5de6c
1 parent ec5db11
commit 2e5de6c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/presets/base-worker.ts b/src/presets/base-worker.ts
@@ -4,6 +4,6 @@ export const baseWorker = defineNitroPreset({
   entry: null, // Abstract
   node: false,
   minify: true,
-  externals: false,
+  noExternals: true,
   inlineDynamicImports: true // iffe does not support code-splitting
 })
diff --git a/src/rollup/config.ts b/src/rollup/config.ts
@@ -234,7 +234,7 @@ export const plugins = [
   }))
 
   // Externals Plugin
-  if (nitro.options.externals) {
+  if (!nitro.options.noExternals) {
     rollupConfig.plugins.push(externals(defu(nitro.options.externals as any, {
       outDir: nitro.options.output.serverDir,
       moduleDirectories: nitro.options.nodeModulesDirs,

diff --git a/src/types/nitro.ts b/src/types/nitro.ts
@@ -133,7 +133,8 @@ export interface NitroOptions {
   esbuild?: {
     options?: EsbuildOptions
   }
-  externals: boolean | NodeExternalsOptions
+  noExternals: boolean,
+  externals: NodeExternalsOptions
   analyze: false | PluginVisualizerOptions
   replace: Record<string, string | ((id: string) => string)>