-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudflare-pages): rewrite with module syntax #1004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1004 +/- ##
==========================================
- Coverage 67.69% 67.59% -0.11%
==========================================
Files 60 61 +1
Lines 6167 6171 +4
Branches 692 693 +1
==========================================
- Hits 4175 4171 -4
- Misses 1982 1989 +7
- Partials 10 11 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7 tasks
Will this now enable folks who use the regular cloudflare preset to also get access to cloudflare ENV and bindings? π |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This PR introduces several improvements to the (currently experimental) cloudflare pages preset using module syntax and advanced mode
_worker.js
output.While testing, I noticed zero-configs is broken with
dist
link (it was only supported for Nuxt also since it was doingdist
symlinking and has it as default in CF pages). New output used top-leveldist
instead of.output/public
also making it more consistent with their other FW presets. This is a slightly breaking change for the experimental preset if.output/public
was hardcoded should be changed todist
Next steps: Supporting
_redirects
and_headers
Also new in this preset: We use local fetch to directly generate response. it should make normalization more consistent in single place (in unenv
π Checklist