docs(cache): improve documentation and cachedFunction default options
#1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Live Preview ready!
|
Codecov Report
@@ Coverage Diff @@
## main #1011 +/- ##
=======================================
Coverage 67.66% 67.66%
=======================================
Files 60 60
Lines 6161 6161
Branches 692 692
=======================================
Hits 4169 4169
Misses 1982 1982
Partials 10 10 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pi0
changed the title
cachedFunction default optionscachedFunction default options
pi0
reviewed
Mar 3, 2023
pi0
reviewed
Mar 3, 2023
| ) { | ||
| opts = { ...defaultCacheOptions, ...opts }; | ||
|
|
||
| const pending: { [key: string]: Promise<T> } = {}; | ||
|
|
||
| // Normalize cache params | ||
| const group = opts.group || "nitro"; | ||
| const group = opts.group || "nitro/functions"; |
There was a problem hiding this comment.
This is breaking change as invalidates all current prod deployment namespaces 😅
pi0
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Improve a lot the documentation for the Cache API as well as:
cachedFunctiontonitro/functionscachedFunctionlikecachedEventHandlerDocs preview
📝 Checklist