Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add static preset #1127

Merged
merged 6 commits into from
Apr 12, 2023
Merged

feat: add static preset #1127

merged 6 commits into from
Apr 12, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #797

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a basic static preset that can be extended to create vercel-static, github-pages and more.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1127 (c110817) into main (de7e59e) will increase coverage by 0.10%.
The diff coverage is 88.31%.

❗ Current head c110817 differs from pull request most recent head a2beecc. Consider uploading reports for the commit a2beecc to get more accurate results

@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
+ Coverage   67.81%   67.92%   +0.10%     
==========================================
  Files          64       65       +1     
  Lines        6403     6406       +3     
  Branches      713      709       -4     
==========================================
+ Hits         4342     4351       +9     
+ Misses       2047     2041       -6     
  Partials       14       14              
Impacted Files Coverage Ξ”
src/build.ts 42.13% <71.42%> (+0.89%) ⬆️
src/options.ts 87.73% <80.00%> (+0.20%) ⬆️
src/presets/vercel.ts 77.72% <92.30%> (+0.93%) ⬆️
src/presets/index.ts 100.00% <100.00%> (ΓΈ)
src/presets/netlify.ts 59.62% <100.00%> (-0.98%) ⬇️
src/presets/static.ts 100.00% <100.00%> (ΓΈ)
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title feat: add base-static preset feat: add static preset Apr 12, 2023
@danielroe
Copy link
Member Author

danielroe commented Apr 12, 2023

It can't be named static as it is a reserved word in JS. (Happy if you have any other ideas/recommendations!)

@pi0
Copy link
Member

pi0 commented Apr 12, 2023

Actually object keys used for mapping can be. added a fix to bypass that :)

@pi0 pi0 merged commit a45623d into main Apr 12, 2023
@pi0 pi0 deleted the feat/static-preset branch April 12, 2023 15:39
@pi0 pi0 mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static preset
2 participants