Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update serverAssets example #1156

Merged
merged 3 commits into from
Apr 17, 2023
Merged

docs: update serverAssets example #1156

merged 3 commits into from
Apr 17, 2023

Conversation

maou-shonen
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The serverAssets example for config in the current docs is confusing for first-timers, (it took me 30 minutes to find the problem)
And there is no way to easily find errors from useStorage().getKeys() or logs πŸ˜…

documentation example ./server/templates
Look for {srcDir}/server/templates in nitro
Look for {srcDir}/server/server/templates in nuxt3
I don't think this should fit the vast majority of use cases

I hope that PR can help the next person who uses this function to use this function more easily and correctly.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Apr 17, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 84de536

docs/content/1.guide/6.assets.md Outdated Show resolved Hide resolved
docs/content/1.guide/6.assets.md Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 490f0ab into nitrojs:main Apr 17, 2023
@pi0 pi0 mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants