-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudflare-module, cloudflare-pages): experimental dynamic imports #1172
Conversation
Thanks for PR. I think previously there were issues with module format and dynamic chunks (globalThis injection). I will double check this you can also try on a nuxt project :) |
Codecov Report
@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
- Coverage 77.80% 77.70% -0.10%
==========================================
Files 76 76
Lines 7816 7835 +19
Branches 797 801 +4
==========================================
+ Hits 6081 6088 +7
- Misses 1732 1744 +12
Partials 3 3
|
β Live Preview ready!
|
Faster than light |
Thanks for this initiative @danielroe, @dario-piotrowicz π I have made some small refactors to allow enabling this experiment via |
π Linked issue
β Type of change
π Description
This adds support for dynamic imports with CF modules following cloudflare/workers-sdk#2769. (Feature coming soon to CF Pages too: merged via #1531 by @dario-piotrowicz to this PR)
Experiment can be enabled by setting
NITRO_EXP_CLOUDFLARE_DYNAMIC_IMPORTS
environment variable.Pending: cloudflare/workers-sdk#3707
TODO:
__STATIC_CONTENT_MANIFEST
import supportrules
info (and console warning)π Checklist