Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-server): support listening to unix sockets using NITRO_UNIX_SOCKET #1201

Merged
merged 13 commits into from
Aug 20, 2023

Conversation

uroybd
Copy link
Contributor

@uroybd uroybd commented Apr 30, 2023

πŸ”— Linked issue

Resolves #1129

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR implements the mechanism necessary to serve over the UNIX domain socket.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Apr 30, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 93422c6

@pi0 pi0 changed the title feat: Added support for UNIX Socket feat(node): support listening to unix sockets using NITRO_SOCKET May 3, 2023
@Hebilicious Hebilicious added the enhancement New feature or request label Jun 30, 2023 — with Volta.net
@Hebilicious Hebilicious self-assigned this Jun 30, 2023
@Hebilicious Hebilicious self-requested a review June 30, 2023 19:20
@Hebilicious Hebilicious added the good first issue Good for newcomers label Jun 30, 2023
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #1201 (ddbaf29) into main (4a6cbcb) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head ddbaf29 differs from pull request most recent head 93422c6. Consider uploading reports for the commit 93422c6 to get more accurate results

@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
- Coverage   77.89%   77.80%   -0.09%     
==========================================
  Files          76       76              
  Lines        7816     7816              
  Branches      800      797       -3     
==========================================
- Hits         6088     6081       -7     
- Misses       1726     1732       +6     
- Partials        2        3       +1     

see 2 files with indirect coverage changes

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have updated implementation to be simplified and also support TLS sockets.

@pi0 pi0 changed the title feat(node): support listening to unix sockets using NITRO_SOCKET feat(node-server): support listening to unix sockets using NITRO_SOCKET Aug 20, 2023
@pi0 pi0 changed the title feat(node-server): support listening to unix sockets using NITRO_SOCKET feat(node-server): support listening to unix sockets using NITRO_UNIX_SOCKET Aug 20, 2023
@pi0 pi0 merged commit 6a1ea5c into nitrojs:main Aug 20, 2023
6 checks passed
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UNIX socket support
3 participants