Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add koyeb preset #1248

Merged
merged 8 commits into from
Feb 27, 2024
Merged

feat: add koyeb preset #1248

merged 8 commits into from
Feb 27, 2024

Conversation

imchairmanm
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a basic preset to for Koyeb. Includes documentation to build and deploy using both Koyeb's control panel and CLI tool.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented May 17, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview b88336a

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 76.84%. Comparing base (e8fa771) to head (b88336a).
Report is 166 commits behind head on main.

❗ Current head b88336a differs from pull request most recent head 5c97a6b. Consider uploading reports for the commit 5c97a6b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1248       +/-   ##
===========================================
+ Coverage   51.94%   76.84%   +24.89%     
===========================================
  Files         174       72      -102     
  Lines       12035     7323     -4712     
  Branches      913      729      -184     
===========================================
- Hits         6252     5627      -625     
+ Misses       5686     1695     -3991     
+ Partials       97        1       -96     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@manniL manniL requested a review from pi0 June 26, 2023 09:19
@Hebilicious Hebilicious assigned pi0 and unassigned pi0 Jun 30, 2023
@Hebilicious Hebilicious removed the request for review from pi0 June 30, 2023 19:18
@Hebilicious Hebilicious self-assigned this Jun 30, 2023
@Hebilicious Hebilicious self-requested a review June 30, 2023 19:18
Copy link
Contributor

@Hebilicious Hebilicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of being thorough, we could add the instructions for deploying with Docker too https://www.koyeb.com/docs/deploy/nuxt#deploy-to-koyeb-using-a-pre-built-container

Hebilicious
Hebilicious previously approved these changes Jul 2, 2023
@atinux
Copy link
Collaborator

atinux commented Jul 13, 2023

Wondering if this is necessary to create a koyeb preset since it is juste the node-server preset.

Adding documentation though is nice.

@pi0
Copy link
Member

pi0 commented Jul 13, 2023

@atinux Yes we do need a preset for officially listed deployment providers so that we can handle possible auto configs also for the future.

I still need to go though this but at least docker file generation could be automated (and extended from generated one).

@pi0 pi0 removed the ready label Jul 13, 2023
Copy link
Contributor

@pi0 I don't think generating a docker file makes sense as they're only used for custom koyeb builds/deployments, and a zero config deployment can be done without one (just the cli commands)

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it got delayed. Let's progress πŸ‘πŸΌ

@pi0 pi0 merged commit 508cfc6 into nitrojs:main Feb 27, 2024
4 checks passed
@imchairmanm imchairmanm deleted the feat/koyeb branch February 27, 2024 18:13
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants