-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add koyeb preset #1248
feat: add koyeb preset #1248
Conversation
β Live Preview ready!
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #1248 +/- ##
===========================================
+ Coverage 51.94% 76.84% +24.89%
===========================================
Files 174 72 -102
Lines 12035 7323 -4712
Branches 913 729 -184
===========================================
- Hits 6252 5627 -625
+ Misses 5686 1695 -3991
+ Partials 97 1 -96 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of being thorough, we could add the instructions for deploying with Docker too https://www.koyeb.com/docs/deploy/nuxt#deploy-to-koyeb-using-a-pre-built-container
Wondering if this is necessary to create a Adding documentation though is nice. |
@atinux Yes we do need a preset for officially listed deployment providers so that we can handle possible auto configs also for the future. I still need to go though this but at least docker file generation could be automated (and extended from generated one). |
@pi0 I don't think generating a docker file makes sense as they're only used for custom koyeb builds/deployments, and a zero config deployment can be done without one (just the cli commands) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it got delayed. Let's progress ππΌ
π Linked issue
β Type of change
π Description
This adds a basic preset to for Koyeb. Includes documentation to build and deploy using both Koyeb's control panel and CLI tool.
π Checklist