feat: type nitro app runtime hooks #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1316 +/- ##
==========================================
+ Coverage 77.00% 77.03% +0.03%
==========================================
Files 68 68
Lines 6848 6859 +11
Branches 686 686
==========================================
+ Hits 5273 5284 +11
Misses 1574 1574
Partials 1 1
|
Hebilicious
reviewed
Jun 17, 2023
| @@ -16,3 +19,11 @@ declare module "h3" { | |||
| $fetch: typeof globalThis.fetch; | |||
| } | |||
| } | |||
|
|
|||
| export interface RuntimeNitroHooks { | |||
| "render:response": ( | |||
There was a problem hiding this comment.
There's "render:html" too right ?
There was a problem hiding this comment.
Quite right! But that is Nuxt-specific and so Nuxt would augment this interface with that hook, as well as the island render hook.
|
Just FYI, I picked previous interface name to align with Nuxt's |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#21593 (comment)
β Type of change
π Description
This addresses a TODO comment to allow nitroApp hooks to be typed (and extended via module augmentation).
π Checklist