Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect static flag when auto detecting preset #1321

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When using static presets, if we are passing an override we should pay attention to this early on or we run the risk of adding hooks from non-static preset even though we finally resolve to static preset.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 19, 2023
@danielroe danielroe requested a review from pi0 June 19, 2023 11:16
@danielroe danielroe self-assigned this Jun 19, 2023
@pi0 pi0 changed the title fix: use overrides static when detecting preset fix: respect static flag when auto detecting preset Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1321 (6ae97e7) into main (46f4ddf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1321   +/-   ##
=======================================
  Coverage   76.22%   76.22%           
=======================================
  Files          68       68           
  Lines        6953     6953           
  Branches      686      686           
=======================================
  Hits         5300     5300           
  Misses       1652     1652           
  Partials        1        1           
Impacted Files Coverage Ξ”
src/options.ts 94.33% <100.00%> (ΓΈ)

@pi0 pi0 merged commit 20078be into main Jun 19, 2023
@pi0 pi0 deleted the fix/static-detect branch June 19, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants