-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support exportConditions
and add worker default conditions
#1401
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
==========================================
+ Coverage 76.73% 76.79% +0.05%
==========================================
Files 71 71
Lines 7273 7309 +36
Branches 727 729 +2
==========================================
+ Hits 5581 5613 +32
- Misses 1691 1695 +4
Partials 1 1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than hard coding details about presets in the rollup config, perhaps we could have the export conditions set in the options and specifically in each preset?
That would also make it possible for users to configure this, and keep the core rollup configuration generic.
@pi0 Regarding |
exportConditions
and add platform defaults
exportConditions
and add platform defaultsexportConditions
and add worker default conditions
π Linked issue
Resolves #1371
Resolves #83
Resolves #1123
Resolves nuxt/nuxt#21571
β Type of change
π Description
This works locally, I tested it against https://github.com/Hebilicious/authjs-nuxt/ which previously needed
And now it works π
π Checklist