-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deno-deploy): treat all https://
modules as external
#1438
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1438 +/- ##
=======================================
Coverage 76.17% 76.17%
=======================================
Files 73 73
Lines 7437 7437
Branches 728 728
=======================================
Hits 5665 5665
Misses 1771 1771
Partials 1 1
|
@AaronDewes Can you please confirm if https://github.com/rollup/rollup/releases/tag/v3.26.3 is resolving our issue? |
Yes, it is. I'll update this PR to include an update to rollup. I also changed it so Nitro now treats all "https://" imports as external (as you suggested), so this PR is still relevant. |
https://
modules as external
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
π Linked issue
#1432
β Type of change
π Description
Rollup 3.26.2 (accidentally?) made a breaking change in the handling of
manualChunks
. This updates rollup to a fixed version, and also changes the config so that allhttps://
modules in Deno are treated external.π Checklist