Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deno-deploy): treat all https:// modules as external #1438

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

AaronDewes
Copy link
Contributor

@AaronDewes AaronDewes commented Jul 15, 2023

πŸ”— Linked issue

#1432

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Rollup 3.26.2 (accidentally?) made a breaking change in the handling of manualChunks. This updates rollup to a fixed version, and also changes the config so that all https:// modules in Deno are treated external.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix(rollup): Fix manualChunks for Deno Deploy preset fix(deno-deploy): explicitly check for externals in manual chunks Jul 15, 2023
src/presets/deno-deploy.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #1438 (2642f93) into main (e87e2ba) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1438   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files          73       73           
  Lines        7437     7437           
  Branches      728      728           
=======================================
  Hits         5665     5665           
  Misses       1771     1771           
  Partials        1        1           
Impacted Files Coverage Ξ”
src/presets/deno-deploy.ts 100.00% <100.00%> (ΓΈ)

@AaronDewes AaronDewes changed the title fix(deno-deploy): explicitly check for externals in manual chunks fix(deno-deploy): Treat all https:// modules as external Jul 18, 2023
@pi0
Copy link
Member

pi0 commented Jul 18, 2023

@AaronDewes Can you please confirm if https://github.com/rollup/rollup/releases/tag/v3.26.3 is resolving our issue?

@AaronDewes
Copy link
Contributor Author

Yes, it is. I'll update this PR to include an update to rollup. I also changed it so Nitro now treats all "https://" imports as external (as you suggested), so this PR is still relevant.

@pi0 pi0 changed the title fix(deno-deploy): Treat all https:// modules as external fix(deno-deploy): treat all https:// modules as external Jul 18, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pi0 pi0 merged commit dd14c23 into nitrojs:main Jul 19, 2023
@AaronDewes AaronDewes deleted the fix-deno-deploy-rollup-3-26-2 branch July 19, 2023 12:16
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants