-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firebase): add support for 2nd generation functions #1500
Conversation
✅ Live Preview ready!
|
firebase
presetfirebase
preset
Codecov Report
@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
+ Coverage 76.47% 76.50% +0.03%
==========================================
Files 73 73
Lines 7591 7594 +3
Branches 757 757
==========================================
+ Hits 5805 5810 +5
+ Misses 1785 1783 -2
Partials 1 1
|
@JamieCurnow It was really hard for me to create a code review with all of this so I created a fork of your PR while keeping all the commits. Let me know what you think 🙂 |
firebase
presetfirebase
): add support for 2nd generation functions
firebase
): add support for 2nd generation functions
Thanks for quick PR @JamieCurnow and all followup ❤️ Let's hope we get out of this situation soon and keep improving preset directly on one main branch 😅 PS: I have sent you an email regarding to join discord server to collaborate closely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@posva Just adding some of the suggestions from @pi0 here. I've realised that we need to also update the doc changes now to account for the gen
selection and to note that the node version can be pinned via the new nodeVersion
key. I'm happy to make these changes - may be easier to add me as a collaborator to your fork? Otherwise, let me know and I'll make a PR to your fork again if you want me to jump on this 🙏
Co-authored-by: Jamie Curnow <jamie@island-web.ca>
Co-authored-by: Jamie Curnow <jamie@island-web.ca>
ac52be4
to
328dab3
Compare
Thanks you all for contributing on this preset ❤️ It looks amazing! To move forward i have made some minor refactors as well as docs update about development. Feel free to try it and make PRs directly into the main branch. BTW we also need to add local tests |
Hi! Thx!! |
Hi dear @snsxn. you can try with edge channel: https://nitro.unjs.io/guide/getting-started#edge-release-channel |
when running firebase emulator it seems is missing region parameter. Here is the suggestion which could help:
|
🔗 Linked issue
Forked from #1142
Resolves #1141
Resolves #666
Resolves #90
This PR adds a
fireabse.gen
option instead offirebase.v2
of the original PR to allow customizing gen 2 and gen 1 functions. It also allows passing other options for the functions. This assumes you are only using one generation at the same time (which, outside of migrations should be the case).❓ Type of change
📚 Description
📝 Checklist