fix(prerender): call prerender:route
before freeing up memory
#1537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
With #1536, we are freeing up route contents from memory but this was causing
prender:route
to lose access to the route contents.This PR fixes this by fixing the ordering and calling the hook directly inside
generateRoute
before freeing up memory and also simplifying the code. (previously we were wrongly catching unhandled internal errors as route errors now it uses simple console log to only avoid hiding edge cases with internal nitro bugs)π Checklist