-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use decoded asset id to access prerendered asset header overrides #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
changed the title
feat: preserve prerendered asset content-type header
test: add test for content-type
Aug 16, 2023
pi0
reviewed
Aug 16, 2023
danielroe
changed the title
test: add test for content-type
fix: use decoded asset id to access prerendered asset header overrides
Aug 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #1588 +/- ##
=======================================
Coverage 76.26% 76.26%
=======================================
Files 76 76
Lines 7799 7799
Branches 781 781
=======================================
Hits 5948 5948
Misses 1849 1849
Partials 2 2
|
pi0
approved these changes
Aug 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Add test - sorry!
π Checklist