-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(prerender): allow disabling html sub-folders #1676
Conversation
82571b7
to
3de44f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
+ Coverage 77.78% 77.80% +0.02%
==========================================
Files 76 76
Lines 7827 7839 +12
Branches 804 805 +1
==========================================
+ Hits 6088 6099 +11
- Misses 1737 1738 +1
Partials 2 2
|
@danielroe I think we can move forward to test on edge directly and revert if any issues before patch release ππΌ |
FYI: 11a2412 Would be nice to think of updating the docs when adding new options π |
Thanks! And yes we should automate it sometime soon similar to nuxt options... Also after testing, this option shall be automatically enabled for providers. That's why merged as fix rather than feat. |
I don't think we need to automate this as we can just better explain the configuration and it does not take much time to add in docs. It's just a process we need to get used to. |
Without automation it is impossible to not forget and keep docs in sync (with version as well). I plan to do this for the upcming h3 docs as well... |
Even if we list the existing options in the docs, we should write JSDOC comments to explain what they do (so that its reflected in TS), a lot of the options are not documented anywhere, or just in their implementation PR currently. |
@Hebilicious yes true. that's the plan to use jsdocs (similar to nuxt) and automatically extract them to the docs kept in sync :) |
π Linked issue
Related: #1394, #607
β Type of change
π Description
This PR allows disabling prerendering in subfolders.
It also includes a potential fix for cloudflare pages/vercel presets, which I need to test. (Opening PR in the interim to get feedback on the API/implementation.)I think safer to merge this first and treat cf/vercel preset issues separately.
π Checklist