Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): don't use invalid port #1697

Closed
wants to merge 4 commits into from
Closed

fix(node): don't use invalid port #1697

wants to merge 4 commits into from

Conversation

tidan-16
Copy link

@tidan-16 tidan-16 commented Sep 5, 2023

πŸ”— Linked issue

nuxt/nuxt#22961

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I have change the condition a little to the node-server.ts file. It checks if the port is not null and if it is NaN, it puts the port (string) inside the path variable instead, wich resolve the issue for iisnode. Iisnode uses Named pipe instead of port numbers. Please check issue more infos

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title Fix: make node-server.ts accept iisnode named pipe fix(iisnode): accept named pipe Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #1697 (f8cb3c5) into main (5639f5b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1697   +/-   ##
=======================================
  Coverage   77.29%   77.29%           
=======================================
  Files          75       75           
  Lines        7893     7893           
  Branches      805      805           
=======================================
  Hits         6101     6101           
  Misses       1790     1790           
  Partials        2        2           

@pi0 pi0 changed the title fix(iisnode): accept named pipe fix(node): accept named pipe Sep 7, 2023
@pi0 pi0 added the pending label Sep 7, 2023
@tidan-16
Copy link
Author

tidan-16 commented Sep 11, 2023

Any updates?

@pi0 pi0 changed the title fix(node): accept named pipe fix(node): don't use invalid port Oct 3, 2023
@pi0
Copy link
Member

pi0 commented Oct 3, 2023

Hi dear @tidan-16. Thanks for spending time on making pull request and sorry for delay i needed time to properly setup a local IIS environment and probably check all possible cases.

#1783 fixes this issue specifically for iis-node that does this strange behavior.

I had been thinking of introducing this also as a general fix but seems unsafe for all node server presets to silently do such a conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants