Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pnpm shell-emulator for windows local development #1828

Merged
merged 7 commits into from
Oct 18, 2023
Merged

chore: use pnpm shell-emulator for windows local development #1828

merged 7 commits into from
Oct 18, 2023

Conversation

HigherOrderLogic
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Use cross-env to set envitonment variables to improve dev exprerience on Windows.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #1828 (c09ca2d) into main (d391b29) will increase coverage by 0.11%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

❗ Current head c09ca2d differs from pull request most recent head fd62fad. Consider uploading reports for the commit fd62fad to get more accurate results

@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
+ Coverage   52.24%   52.35%   +0.11%     
==========================================
  Files         170      170              
  Lines       11754    11744      -10     
  Branches      900      904       +4     
==========================================
+ Hits         6141     6149       +8     
+ Misses       5516     5499      -17     
+ Partials       97       96       -1     

see 3 files with indirect coverage changes

@pi0 pi0 changed the title chore: improve dev DX on windows chore: use cross-env for windows local development Oct 16, 2023
@pi0 pi0 changed the title chore: use cross-env for windows local development chore: use pnpm shell-emulator for windows local development Oct 18, 2023
@pi0
Copy link
Member

pi0 commented Oct 18, 2023

Thanks for PR dear @HigherOrderLogic. Instead of using cross-env, we can enable pnpm's shell-emulator option in order to add windows support. I have pushed the changes.

@pi0 pi0 merged commit f421530 into nitrojs:main Oct 18, 2023
3 of 5 checks passed
@HigherOrderLogic HigherOrderLogic deleted the chore-dev-on-windows branch October 19, 2023 09:18
@pi0 pi0 mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants