Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initialize nitro app before plugins run #1906

Merged
merged 8 commits into from
Sep 20, 2024
Merged

fix: initialize nitro app before plugins run #1906

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5fecd71
fix: initialize nitro app before plugins run
harlan-zw Nov 12, 2023
49bb772
chore: minor fixes
harlan-zw Nov 12, 2023
fd87b14
chore: lint
harlan-zw Nov 12, 2023
3db3866
chore: remove console.log
harlan-zw Nov 12, 2023
e96b992
Merge branch 'v2' into fix/initialize-nitro-app-pre-plugins
pi0 Sep 20, 2024
76341ca
add compat date
pi0 Sep 20, 2024
fe6f965
manual rebase
pi0 Sep 20, 2024
4c63a4e
revert example updates
pi0 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/runtime/internal/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,18 +185,24 @@ function createNitroApp(): NitroApp {
captureError,
};

return app;
}

function runNitroPlugins(nitroApp: NitroApp) {
for (const plugin of plugins) {
try {
plugin(app);
plugin(nitroApp);
} catch (error: any) {
captureError(error, { tags: ["plugin"] });
nitroApp.captureError(error, { tags: ["plugin"] });
throw error;
}
}

return app;
}

export const nitroApp: NitroApp = createNitroApp();

export const useNitroApp = () => nitroApp;
export function useNitroApp() {
return nitroApp;
}

runNitroPlugins(nitroApp);