Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect imports.autoImport: false #2226

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: respect imports.autoImport: false #2226

merged 2 commits into from
Mar 7, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

when imports.autoImport is set to false we should not generate unimport declarations:

declare global {
  const __buildAssetsURL: typeof import('../../node_modules/.pnpm/nuxt@3.10.3_eslint@8.57.0_rollup@3.29.4_typescript@5.4.2_vite@5.1.5_vue-tsc@2.0.6/node_modules/nuxt/dist/core/runtime/nitro/paths')['buildAssetsURL']
  // ...
}

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 March 7, 2024 14:20
@danielroe danielroe self-assigned this Mar 7, 2024
@danielroe danielroe added bug Something isn't working types labels Mar 7, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only can you confirm it still generates #imports type? (it is not auto)

@danielroe
Copy link
Member Author

It does. The only thing we are excluding is the declarations.

danielroe referenced this pull request in nuxt-modules/sanity Mar 7, 2024
@pi0 pi0 merged commit fef3d59 into main Mar 7, 2024
4 of 5 checks passed
@pi0 pi0 deleted the fix/auto-import-falase branch March 7, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants