-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle path negations when scanning public assets #2250
Conversation
Would you mind to add regression test to fixture? |
Will do πΉ Investigating it actually seems that What do you think about custom ignore patterns per publicAssets dir? In Nuxt, we never want to ignore any build output in Alternatively, investigating another approach ... |
Okay, I think we're good to go here, using include rather than ignore patterns allows us to support negated ignore patterns without breaking current behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes!
π Linked issue
β Type of change
π Description
Discovered while triaging issue with nuxt/nuxt#26203, we basically weren't handling ignore patterns beginning with
!
if they did not also start with!*
. (They would end up as part of a directory name.)π Checklist