Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert CapturedErrorContext to interface to allow type augmentation #2393

Merged
merged 2 commits into from
Apr 25, 2024
Merged

refactor: convert CapturedErrorContext to interface to allow type augmentation #2393

merged 2 commits into from
Apr 25, 2024

Conversation

huang-julien
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

hi 👋 this PR converts CapturedErrorContext to an interface to allow users and module authors to augment this type .

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title refactor: convert CapturedErrorContext to interface for type augmentation refactor: convert CapturedErrorContext to interface to allow type augmentation Apr 25, 2024
pi0
pi0 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(this is a good PR please don't get me wrong but please consider adding more context of why PRs are made -- for example specific usecase 🙏🏼 )

@pi0 pi0 merged commit 45ff175 into nitrojs:main Apr 25, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Jun 13, 2024
Closed
pi0 pushed a commit that referenced this pull request Jun 27, 2024
@huang-julien @pi0
refactor: convert CapturedErrorContext to interface to allow type a…
38a7bfe 
…ugmentation (#2393)
@pi0 pi0 mentioned this pull request Jun 27, 2024
Closed
@Barbapapazes Barbapapazes mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huang-julien @pi0