Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudflare-module): support cloudflare:email and cloudflare:queue hooks #2487

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

dalbodeule
Copy link
Contributor

πŸ”— Linked issue

#2480

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The existing Cloudflare-module preset did not have a function that could handle Email.

To solve this, we worked on email handlers.
Similar work was performed with the existing task handler. I'm not sure if it's right to do this.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@dalbodeule dalbodeule changed the title Emailtask feat(cloudflare-module): add Email task handler. from #2480 Jun 2, 2024
@pi0 pi0 changed the title feat(cloudflare-module): add Email task handler. from #2480 feat(cloudflare): add Email task handler. from #2480 Jun 3, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR dear @dalbodeule. I think we can simply refactor this feature to be based on nitro events as long as it is a vendor-specific thing

@pi0 pi0 marked this pull request as draft June 3, 2024 12:34
@pi0 pi0 changed the title feat(cloudflare): add Email task handler. from #2480 feat(cloudflare): support email handler Jun 3, 2024
@dalbodeule
Copy link
Contributor Author

I did what was asked once. Please confirm if this is what you think.

If you make it like this

defineNuxtPlugin((nitroApp) => {
 nitroApp.hooks.hook("cloudflare:email", handler);
})

I want to check whether a pattern is used.

If this is the pattern. I think it would be okay to create a cloudflare:queue handler in the same way.

@dalbodeule dalbodeule marked this pull request as ready for review June 4, 2024 22:04
@pi0 pi0 self-requested a review June 4, 2024 23:38
@dalbodeule dalbodeule changed the title feat(cloudflare): support email handler feat(cloudflare): support cloudflare email, queue handler Jun 8, 2024
@dalbodeule
Copy link
Contributor Author

dalbodeule commented Jun 8, 2024

As a new version of nitro was released, Merge, email handler, and queue handler were added to suit the new version. Request you to check. @pi0

@pi0 pi0 changed the title feat(cloudflare): support cloudflare email, queue handler feat(cloudflare-module): support cloudflare:email and cloudflare:queue hooks Jun 12, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️ (you can test this using nightly channel)

@pi0 pi0 merged commit 9efa3a5 into nitrojs:main Jun 12, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants