-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudflare-module): support cloudflare:email
and cloudflare:queue
hooks
#2487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR dear @dalbodeule. I think we can simply refactor this feature to be based on nitro events as long as it is a vendor-specific thing
I did what was asked once. Please confirm if this is what you think. If you make it like this defineNuxtPlugin((nitroApp) => {
nitroApp.hooks.hook("cloudflare:email", handler);
}) I want to check whether a pattern is used. If this is the pattern. I think it would be okay to create a cloudflare:queue handler in the same way. |
# Conflicts: # src/runtime/index.ts # src/runtime/types.ts
As a new version of nitro was released, Merge, email handler, and queue handler were added to suit the new version. Request you to check. @pi0 |
cloudflare:email
and cloudflare:queue
hooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks β€οΈ (you can test this using nightly channel)
π Linked issue
#2480
β Type of change
π Description
The existing Cloudflare-module preset did not have a function that could handle Email.
To solve this, we worked on email handlers.
Similar work was performed with the existing task handler. I'm not sure if it's right to do this.
π Checklist