Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more compatibility for import from nitropack/runtime/* #2501

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 7, 2024

With #2473 refactors, all runtime imports should be from nitropack/runtime.

This PR resolves #2499 (for nitropack/runtime/plugin) and possible cases alike that users used nitropack/runtime/* and #internal/nitro/* paths:

  • nitropack/runtime/app
  • nitropack/runtime/cache
  • nitropack/runtime/config
  • nitropack/runtime/context
  • nitropack/runtime/database
  • nitropack/runtime/error
  • nitropack/runtime/plugin
  • nitropack/runtime/strorage
  • nitropack/runtime/task
  • nitropack/runtime/utils

@pi0 pi0 changed the title fix: keep compatibility for import {} from 'nitropack/runtime/plugin fix: keep compatibility for import from nitropack/runtime/plugin Jun 7, 2024
@pi0 pi0 marked this pull request as draft June 7, 2024 13:57
@pi0 pi0 changed the title fix: keep compatibility for import from nitropack/runtime/plugin fix: more compatibility for import from nitropack/runtime/* Jun 7, 2024
@pi0 pi0 marked this pull request as ready for review June 7, 2024 14:11
@pi0 pi0 merged commit e316df3 into main Jun 7, 2024
4 of 5 checks passed
@pi0 pi0 deleted the fix/compat branch June 7, 2024 14:13
@pi0 pi0 mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nitropack/runtime/plugin for compatibility
1 participant