Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): resolve modules with esm compatibility #2514

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix(core): resolve modules with esm compatibility #2514

merged 1 commit into from
Jun 12, 2024

Conversation

94726
Copy link
Contributor

@94726 94726 commented Jun 12, 2024

🔗 Linked issue

#2512

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This enables esmResolve for loading modules, so that subpaths are correctly imported.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

pi0
pi0 reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title fix(core): import modules as esm fix(core): resolve modules with esm compatibility Jun 12, 2024
@pi0 pi0 merged commit 4657ada into nitrojs:main Jun 12, 2024
4 checks passed
@94726 94726 deleted the esmresolve-modules branch June 12, 2024 15:57
@94726 94726 mentioned this pull request Jun 12, 2024
Closed
@pi0 pi0 mentioned this pull request Jun 13, 2024
Closed
pi0 pushed a commit that referenced this pull request Jun 27, 2024
@94726 @pi0
fix(core): resolve modules with esm compatibility (#2514)
0bd8788
@pi0 pi0 mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@94726 @pi0