Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve internal tsconfig.json #2529

Merged
merged 5 commits into from
Jun 14, 2024
Merged

chore: improve internal tsconfig.json #2529

merged 5 commits into from
Jun 14, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A small set of suggested changes for review - a bigger PR will follow enabling noUncheckedIndexedAccess, which will require more code changes.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 June 14, 2024 09:06
@danielroe danielroe self-assigned this Jun 14, 2024
pi0
pi0 reviewed Jun 14, 2024
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@pi0 pi0 changed the base branch from main to v2 June 14, 2024 09:48
@pi0 pi0 changed the base branch from v2 to main June 14, 2024 09:48
@pi0 pi0 merged commit ebeda79 into main Jun 14, 2024
4 of 5 checks passed
@pi0 pi0 deleted the chore/repo-tsconfig branch June 14, 2024 09:48
pi0 pushed a commit that referenced this pull request Jun 14, 2024
@danielroe @pi0
chore: improve internal tsconfig.json (#2529)
2ca8021
davidstackio pushed a commit to davidstackio/nitro that referenced this pull request Aug 7, 2024
@danielroe @davidstackio
chore: improve internal tsconfig.json (nitrojs#2529)
a63d79b
@pi0 pi0 mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0