Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(netlify): use new durable cache-control directive for isr rule #2571

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

serhalp
Copy link
Contributor

@serhalp serhalp commented Jun 28, 2024

πŸ”— Linked issue

N/A - discussed on Discord

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is a follow-up to #2406.

See https://docs.netlify.com/platform/caching/#durable-directive. (This link should go live a bit later today!)

With this change, responses from isr routes will be propagated to the global edge network rather than be local to the CDN node that rendered and served it. This will improve performance and reduce serverless function invocations, in various scenarios.

This won't immediately have any effect since we're gradually rolling out the feature on the platform, but by the time nitro v3 (and frameworks that use it, like nuxt v4) are released it should be fully rolled out.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@serhalp serhalp marked this pull request as ready for review June 28, 2024 14:19
@pi0
Copy link
Member

pi0 commented Jun 28, 2024

So you mind to rebase against v2 branch? πŸ™ (rebased to v2, main branch will get it too: 859de2d)

See https://docs.netlify.com/platform/caching/#durable-directive.

This won't immediately have any effect, but by the time nitro v3 (and
frameworks that use it, like nuxt v4) are released it should be fully
rolled out.
@pi0 pi0 force-pushed the feat/netlify-durable-cache branch from 768b1ca to f9f0716 Compare June 28, 2024 15:02
@pi0 pi0 changed the base branch from main to v2 June 28, 2024 15:02
@pi0 pi0 changed the title feat(netlify): use new durable cache-control directive feat(netlify): use new durable cache-control directive for isr rule Jun 28, 2024
@pi0 pi0 merged commit 8693087 into nitrojs:v2 Jun 28, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants