Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): clarify post handler #2781

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

iiio2
Copy link
Contributor

@iiio2 iiio2 commented Oct 8, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Actually It is my personal opinion. It is a POST method and it works well. But for the POST method almost all time body is required which items the user is providing. So I think for the POST method example if we provide readBody things then it would be slightly more nicer to understand. It will also stay different from GET method which is in test.get.ts.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@iiio2 iiio2 requested a review from pi0 as a code owner October 8, 2024 09:54
@pi0 pi0 merged commit 5960006 into nitrojs:v2 Oct 8, 2024
4 checks passed
@pi0
Copy link
Member

pi0 commented Oct 8, 2024

Thanks!

@iiio2 iiio2 deleted the iiio2/patch-4097 branch October 9, 2024 00:42
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants