Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): change name in package.json #2816

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

iiio2
Copy link
Contributor

@iiio2 iiio2 commented Oct 26, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There are many examples in our Nitro project inside examples folder. For example, in the api-routes folder, the name of the project is example-api-routes in the name field in package.json file. In the same way, in the auto-imports folder, the name in package.json is example-auto-imports. In the cached-handler folder, the name field in package.json is example-cached-handler. But in the websocket folder, the project name was given example-hello-world. I think it would be better to change it to example-websocket for maintaining the naming consistency like all other the projects in package.json.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@iiio2 iiio2 requested a review from pi0 as a code owner October 26, 2024 13:29
@pi0 pi0 merged commit 94203ee into nitrojs:v2 Oct 31, 2024
4 checks passed
@iiio2 iiio2 deleted the iiio2/patch-28897 branch October 31, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants