Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(netlify-legacy): exclude static paths from server handler #2823

Merged

Conversation

serhalp
Copy link
Contributor

@serhalp serhalp commented Oct 31, 2024

πŸ”— Linked issue

N/A - discussed on Discord

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Follow-up to #2822 β€” backporting the same fix to netlify-legacy.

Since it's using "v1" Netlify Functions (https://docs.netlify.com/functions/lambda-compatibility), it doesn't have access to excludedPath and preferStatic, so we implement this with redirects. See the inline comment.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title perf(netlify-legacy): exclude static paths from SSR function perf(netlify-legacy): exclude static paths from server handler Oct 31, 2024
Backporting nitrojs#2822 to the netlify-legacy preset.

Since it's using "v1" Netlify Functions
(https://docs.netlify.com/functions/lambda-compatibility), it doesn't have access to
`excludedPath` and `preferStatic`, so we implement this with redirects.
@serhalp serhalp force-pushed the perf/netlify-legacy/avoid-static-all-asset-invocations branch from 0220664 to 9d88e76 Compare October 31, 2024 14:14
@serhalp serhalp marked this pull request as ready for review October 31, 2024 14:53
@serhalp serhalp requested a review from pi0 as a code owner October 31, 2024 14:53
@serhalp
Copy link
Contributor Author

serhalp commented Oct 31, 2024

@pi0 and here's the backport for netlify-legacy

Here's a manual QA against a nuxt site (nuxt v3, default compat date, i.e. using legacy preset):

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pi0 pi0 merged commit 5a7b3d6 into nitrojs:v2 Oct 31, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants